Skip to content

[Google Enhanced Conversions] Update google enhanced conversions API version to v21 #3341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 21, 2025
Merged

[Google Enhanced Conversions] Update google enhanced conversions API version to v21 #3341

merged 1 commit into from
Oct 21, 2025

Conversation

@harsh-joshi99
Copy link
Contributor

@harsh-joshi99 harsh-joshi99 commented Oct 9, 2025 •
edited
Loading

Upgrading google enhanced conversions API to v21 from v19, since v19 is going to be sunset in Feb 26.

JIRA -> https://twilio-engineering.atlassian.net/browse/STRATCONN-6229

Testing

Testing Document.

Include any additional information about the testing you have completed to
ensure your changes behave as expected. For a speedy review, please check
any of the tasks you completed below during your testing.

  • Added unit tests for new functionality
  • Tested end-to-end using the local server
  • [If destination is already live] Tested for backward compatibility of destination. Note: New required fields are a breaking change.
  • [Segmenters] Tested in the staging environment
  • [Segmenters] [If applicable for this change] Tested for regression with Hadron.

@codecov
Copy link

codecov bot commented Oct 9, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.97%. Comparing base (5d96b8a) to head (10cd3f0).
⚠️ Report is 17 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3341   +/-   ##
=======================================
  Coverage   79.97%   79.97%           
=======================================
  Files        1204     1204           
  Lines       22312    22312           
  Branches     4414     4414           
=======================================
  Hits        17845    17845           
  Misses       3685     3685           
  Partials      782      782

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@harsh-joshi99 harsh-joshi99 requested a review from Copilot October 14, 2025 06:03
Copilot
Copilot AI reviewed Oct 14, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the Google Enhanced Conversions destination to use Google Ads API version v21 instead of v19, as v19 is being sunset in February 2026. This is a necessary API version upgrade to maintain compatibility with Google's services.

  • Updates API version references from v19 to v21 across all action files
  • Updates documentation links to point to v21 API reference
  • Updates test mocks to use v21 error response format

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
userList/index.ts Updated consent documentation links from v19 to v21
userList/generated-types.ts Updated TypeScript interface comments with v21 API links
uploadClickConversion2/index.ts Updated consent documentation links from v19 to v21
uploadClickConversion2/generated-types.ts Updated TypeScript interface comments with v21 API links
uploadClickConversion/index.ts Updated consent documentation links from v19 to v21
uploadClickConversion/generated-types.ts Updated TypeScript interface comments with v21 API links
uploadCallConversion2/index.ts Updated consent documentation links from v19 to v21
uploadCallConversion2/generated-types.ts Updated TypeScript interface comments with v21 API links
uploadCallConversion/index.ts Updated consent documentation links from v19 to v21
uploadCallConversion/generated-types.ts Updated TypeScript interface comments with v21 API links
functions.ts Updated canary API version and error handling documentation link to v21
tests/userList.test.ts Updated test mocks to use v21 error response format
tests/functions.test.ts Updated test API endpoint to use v21

@harsh-joshi99 harsh-joshi99 marked this pull request as ready for review October 14, 2025 06:11
@harsh-joshi99 harsh-joshi99 requested a review from a team as a code owner October 14, 2025 06:11
@abhandage
Copy link
Contributor

abhandage commented Oct 15, 2025 •
edited
Loading

Are we going to release this at once or with feature flag like we did with first party dv360? cc: @varadarajan-tw

@harsh-joshi99
Copy link
Contributor Author

Are we going to release this at once or with feature flag like we did with first party dv360? cc: @varadarajan-tw

With feature flag. It's already setup for this destination. https://github.com/segmentio/action-destinations/blob/main/packages/destination-actions/src/destinations/google-enhanced-conversions/functions.ts#L222

@joe-ayoub-segment joe-ayoub-segment merged commit 4c31e66 into main Oct 21, 2025
15 checks passed
@joe-ayoub-segment joe-ayoub-segment deleted the STRATCONN-6229/gec-upgrade branch October 21, 2025 10:44
@joe-ayoub-segment
Copy link
Contributor

Hi @harsh-joshi99 - PR deployed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@abhandage abhandage abhandage approved these changes

@monutwilio monutwilio monutwilio approved these changes

Assignees

No one assigned

Labels

deploy:push mode:cloud not-partner-eng-review (cloud) Ready for Release team:segment-core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@harsh-joshi99 @abhandage @joe-ayoub-segment @monutwilio